parley icon indicating copy to clipboard operation
parley copied to clipboard

Deferred.getInvocationInfo.proceedToAfterExecSpinlocks error logging

Open wulfsolter opened this issue 5 years ago • 1 comments

Inside a vanilla function() method (as opposed to async/promise etc) in a SailsJS service attempting to access the property of an undefined results in an error that has not triggered creation of an omen, so only getting logging of

5|WW-API | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
5|WW-API | WARNING: Something seems to be wrong with this function.
5|WW-API | It is trying to signal that it has finished AGAIN, after
5|WW-API | already resolving/rejecting once.
5|WW-API | (silently ignoring this...)
5|WW-API |  [?] For more help, visit https://sailsjs.com/support
5|WW-API | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

This PR extends how Deferred.getInvocationInfo.proceedToAfterExecSpinlocks handles passed params - to log out the original error even if no omen exists yet, and to also only log errCbArg if it actually exists.

@mikermcneil I should've done this originally in https://github.com/mikermcneil/parley/pull/6 :)

wulfsolter avatar Nov 26 '19 21:11 wulfsolter

@mikermcneil Can we please look at this, this is a problem with us also.

meetDeveloper avatar Aug 26 '21 02:08 meetDeveloper