spirit2_free
spirit2_free copied to clipboard
mikereidis
Root access required not known
The app description should say that it requires root access. Downloaded from f-drpid
I forget who. Is there a page ?
No, all the code is mine, except the uncopyrightable C include files which are just definitions and aren't code anyway.
On Mon, Jan 26, 2015 at 7:05 AM, Jwalant Natvarlal Soneji < [email protected]> wrote:
Oh... somebody must have had, any other contributors?
— Reply to this email directly or view it on GitHub https://github.com/mikereidis/spirit2_free/issues/6#issuecomment-71451287 .
Oh... this is the app https://f-droid.org/repository/browse/?fdid=fm.a2d.sf
If not you then who has put it there? I hope it's not a macro which grabs apps to link.. :-)
Hey, anyone is free to submit pull requests with build recipes to https://gitlab.com/fdroid/fdroiddata, subject to the inclusion criteria. They do not necessarily have to be submitted by upstream in order to be included in the main F-Droid repo.
As for your actual question about the description mentioning root access, anyone can submit a pull request to https://gitlab.com/fdroid/fdroiddata/blob/master/metadata/fm.a2d.sf.txt updating the description. @mikereidis, I'm not suggesting this is your responsibility, but @jwalantsoneji you are welcome to submit a pull request if you think it is appropriate.
While I'm here, (and off topic) just wanted to thank you for your work on spirit - I purchased it back in the day when I still had the Play Store on my SGS and I used it heaps. Really great to see this source release here, pity I don't have that phone any more.
Filed a merge request to fix that issue: https://gitlab.com/fdroid/fdroiddata/merge_requests/546
Hello, not sure what was changed. The app description on the f-droid doesn't say that it requires root.
@jwalantsoneji is right. It needs root. Says so right when launched.
http://imgur.com/lZD96MU
But the F-Droid page DOES NOT say anything to the effect that root is required!
http://imgur.com/XipoJHC
If it said that root is needed, I wouldn't have downloaded it.
@jwalantsoneji It's because the F-Droid developers must update this on their website as aelmahmoudy commented. I has been merged in https://gitlab.com/fdroid/fdroiddata/commit/5864a2f1f9957eb889d9e3fac608a46e8bb6c508 but the authors hasn't applied it yet. I requested them to do so. Thanks.
