RepoDB icon indicating copy to clipboard operation
RepoDB copied to clipboard

Review: Review the Cursor Pagination Implementation and assess the other DB Providers

Open mikependon opened this issue 5 years ago • 4 comments

The implementation of Cursor Pagination from this code base is quite awesome.

This story will allow us to consider the implementation to be integrated to the core library (RepoDb) or the official extension for SQL Server (RepoDb.SqlServer) if needed/possible. In addition, this User Story is used as a placeholder for Cursor Pagination via other DB Provider (i.e.: MySQL, PostgreSQL and SQLite).

Note: An additional User Stories will be created if needed in order for us to fully integrate the solution to the core library.

Ensure the author of this extension library is notified.

mikependon avatar Nov 01 '20 13:11 mikependon

@mikependon this is great, thank you so much for the complement on my repo!

In fact you have already read my mind. I wanted to ping you soon about the inclusion of the cursor pagination into the core of RepoDb!

I was just waiting to iron out a few more issues/concepts before proposing it.

I'd be happy to create a draft PR over the next couple of weeks if you would like that, or whatever next steps you think would be best.

cajuncoding avatar Nov 01 '20 17:11 cajuncoding

The implementation of Cursor Pagination from this code base is quite awesome.

This story will allow us to consider the implementation to be integrated to the core library (RepoDb) or the official extension for SQL Server (RepoDb.SqlServer) if needed/possible. In addition, this User Story is used as a placeholder for Cursor Pagination via other DB Provider (i.e.: MySQL, PostgreSQL and SQLite).

Note: An additional User Stories will be created if needed in order for us to fully integrate the solution to the core library.

Ensure the author of this extension library is notified.

the link "code base" is broken

chopswil15 avatar Jan 06 '21 12:01 chopswil15

That is because @cajuncoding, the author of the extension library renamed the repository due to GraphQL request. The new code base is found here.

mikependon avatar Jan 06 '21 13:01 mikependon

Sorry about that broken link, I had to rename by request from the HotChocolate core team...they want to keep any other uses of their namespace out of Nuget so renaming GitHub was also needed for consistency.

cajuncoding avatar Jan 06 '21 16:01 cajuncoding