RepoDB icon indicating copy to clipboard operation
RepoDB copied to clipboard

Question: InsertAll in BaseRepository does not return number of inserted rows

Open lucwuyts opened this issue 5 years ago • 5 comments

the method InsertAll in DbRepository does return the number of inserted rows. But InsertAll in BaseRepository does not return this. Docu says it should return this number.

lucwuyts avatar Oct 02 '20 06:10 lucwuyts

Hey, we have a huge Integration Tests that cover this, we would say all Integration Tests are using this method. Also, I personally just tested this one and it works (just now).

Would you be able to provide more context on this User Story? We need to following.

  • Which extension library you are using? With a version would also help.
  • Good thing if you can share the model/table schema itself.
  • Did you use the sync and/or async method?

Or, you can always give more context on your own way.

mikependon avatar Oct 02 '20 06:10 mikependon

Hi Mike, I started experimenting with RepoDB yesterday. Looks good so far, but i'm still struggling with some little problems.

I used the sync version of this method. I used the latest version of RepoDB. (1.12.3)

Look at this source: https://github.com/mikependon/RepoDB/blob/master/RepoDb/RepoDb/Operations/BaseRepository/InsertAll.cs

The method InsertAll is defined "void" (The async version also is just returning Task)

It's no big deal, but your doc says "/// The number of inserted rows."

lucwuyts avatar Oct 02 '20 06:10 lucwuyts

@lucwuyts - hmmmm... Interesting.

image

mikependon avatar Oct 02 '20 06:10 mikependon

My fault.... I should have looked in RepoDB.Core
Sorry about that

lucwuyts avatar Oct 02 '20 06:10 lucwuyts

You are looking at the old one. You should look here.

mikependon avatar Oct 02 '20 06:10 mikependon