RepoDB icon indicating copy to clipboard operation
RepoDB copied to clipboard

Enhancement: Remove the QueryBuilder on the IStatementBuilder interface methods

Open mikependon opened this issue 3 years ago • 1 comments

Describe the enhancement

To simplify the calls to the IStatementBuilder methods without requiring the caller to explicitly instantiate the QueryBuilder class, we therefore proposing to remove this argument in all the methods of the Statement Builders.

Current implementation is below.

public virtual string CreateQuery(QueryBuilder queryBuilder,
            string tableName,
            IEnumerable<Field> fields,
            QueryGroup where = null,
            IEnumerable<OrderField> orderBy = null,
            int? top = null,
            string hints = null)

Proposal impelentation is below.

public virtual string CreateQuery(string tableName,
            IEnumerable<Field> fields,
            QueryGroup where = null,
            IEnumerable<OrderField> orderBy = null,
            int? top = null,
            string hints = null)

Additional Context

All the extended libraries (i.e: RepoDb.SqlServer, RepoDb.PostgreSql, RepoDb.MySql, RepoDb.SqLite) must also follow the structure.

Acceptance Criteria

All the existing Unit Tests and Integration Tests must be updated to conform with the proposal and must be executed successfully.

mikependon avatar Jul 22 '22 14:07 mikependon

Related: https://github.com/mikependon/RepoDB/issues/1036

mikependon avatar Jul 22 '22 14:07 mikependon

This will be available in the releases > RepoDB v1.12.10.

mikependon avatar Aug 24 '22 15:08 mikependon