Mike Oliphant
Mike Oliphant
Strangely, I'm not seeing DC offsets now even with the DC blocker code completely removed. It definitely *used* to be a problem: https://github.com/mikeoliphant/neural-amp-modeler-lv2/issues/41
I'm seeing the same behavior (no DC offset even with DC offset correction code removed) in the official NAM plugin.
I tried with a really old version of the lv2 plugin, and I *still* couldn't get a DC offset to happen. Maybe I'm just not trying the right models (although...
You just need to comment out the whole DC blocker loop: https://github.com/mikeoliphant/neural-amp-modeler-lv2/blob/72fd4a1e3d6118f52be7f609708209535e8a9e24/src/nam_plugin.cpp#L293-L302
I'd been planning to revisit this once I had a model that was showing dc offset issues so that I could see what (if any) trade-off a subtler high pass...
I went ahead and removed the dc blocker, since it seemed to be doing more harm than good.