HidDevices.EnumerateHidDevices memory leak due to yield

[jj-jabb]

Running on both XP (32bit) and Windows 7 (64bit) with the Logitech G13 controller - I've noticed severe memory leaking and it appears to be caused by using the yield keyword at line 69, preventing NativeMethods.SetupDiDestroyDeviceInfoList(deviceInfoSet) at line 72 from ever being reached. This can be fixed by removing the yield statement, moving var devices = new List() at line 51 to before the if statement, and returning devices.

Thanks for the great work!

[mitchjs]

im not sure thats the right way to fix... this to me is the right way... line 69 onward: //yield return devicePath; } } NativeMethods.SetupDiDestroyDeviceInfoList(deviceInfoSet);

foreach (string devicePath in devices) { yield return devicePath; }

                            }

[mitchjs]

so that it builds the list of devicepaths... then yield a devicepath for each literation though the IEnumerable and this allows you to stop your illertation at any point, and not have deviceInfoSet left in memory

[jj-jabb]

devices is already an IEnumerable - might as well just return it instead of yielding each string.

[mitchjs]

true, i guess, but then we cant use the cool YIELD statement :)

[jrockfl]

Thank you so much, this cured my memory leak!

[jw834ksj43]

Worked for me also. Thanks!

[ghost]

Can someone make a pull request for this and possibly unit tests?