luceneutil icon indicating copy to clipboard operation
luceneutil copied to clipboard

StatisticsHelper: Fix lack of "garbage generated" data (zeros)

Open dsmiley opened this issue 7 years ago • 3 comments
trafficstars

StatisticsHelper: Remove attempts to "setDaemon" the stats polling thread And update memory status one final time in stopStatistics().

Closes #24

dsmiley avatar Sep 20 '18 04:09 dsmiley

I'm a little confused on what the bug was here.

E.g. were you seeing all 0 for the GC statistics at the end of all benchmark runs? Because we were missing the final run call during stopStatistics?

mikemccand avatar Mar 04 '20 14:03 mikemccand

I'm a little confused on what the bug was here.

E.g. were you seeing all 0 for the GC statistics at the end of all benchmark runs? Because we were missing the final run call during stopStatistics?

They will show as "N/A" because hasMemoryPools is false because some of the pool names were not correctly identified. I think there was a separate issue to which I have comments in the issue pertaining to setDaemon etc. and other aspects here. It's been many months for this part and I'm less sure of that.

dsmiley avatar Apr 21 '20 18:04 dsmiley