mail icon indicating copy to clipboard operation
mail copied to clipboard

Remove downcase! method from sanitize function in ContentTypeField

Open RemcodM opened this issue 4 years ago • 2 comments

Fixes #1398

This change removes the sequence of code that downcases the Content-Type header value. If I should believe the specs, it should serve no purpose. Only 2 specs break because of the charset being returned in capital letters instead of downcased as before.

This fixes the problem is which encoding is broken by downcasing, such as the example with base64 provided in #1398

RemcodM avatar Jun 24 '20 12:06 RemcodM

nice find! I think you're right, the code should be removed. Could you add a test case according to your example to avoid further regressions?

ahorek avatar Jun 24 '20 16:06 ahorek

Hi there @RemcodM could you please rebase this onto latest master? This will then trigger all the current specs we have.

mikel avatar Dec 03 '22 09:12 mikel