mail icon indicating copy to clipboard operation
mail copied to clipboard

get rid of rescue nil

Open ahorek opened this issue 5 years ago • 3 comments

not a good idea, nil check should be enough

ahorek avatar Dec 19 '18 02:12 ahorek

Believe this is meant to catch parsing errors. Agree that blanket rescue nil is too broad, though. We can be more precise.

jeremy avatar Dec 19 '18 16:12 jeremy

I tested this change with 3 test suites (mail, actionmailer and redmine) wihout any regression. These methods aren't responsible for parsing, it should be just a lookup. Rescuing StandardError is too cautious, but well, still better than rescue Exception 😈

ahorek avatar Dec 19 '18 22:12 ahorek

rebased

ahorek avatar Dec 03 '22 10:12 ahorek