[Code]: NC uses deprecated SecKeychain APIs

[mikekazakov]

Version of Nimble Commander

v1.6, any

Distribution Type

Downloaded directly from the website

Expected Result

NC should compile without deprecation warnings.

Actual Result

All of SecKeychain is deprecated now: API_DEPRECATED("SecKeychain is deprecated", macos(10.2, 10.10)) API_UNAVAILABLE(ios, watchos, tvos, macCatalyst); The deprecation is currently silenced to allow compilation (-werror)

Steps to reproduce

Go into Source/Utility/source/KeychainServices.cpp, the code uses e.g. https://developer.apple.com/documentation/security/1397763-seckeychainfindinternetpassword?language=objc

Additional Information

(migrating existing issues/tasks from the previously used internal issue tracker)
Might be useful related links:
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/crypto/apple_keychain_mac.cc https://bugs.chromium.org/p/chromium/issues/detail?id=1348251 https://chromium.googlesource.com/chromium/src/+/refs/heads/main/crypto/apple_keychain_ios.mm