Mike Gelfand

Results 257 comments of Mike Gelfand

> This is usually where i contemplate getting a fresh clone. Go for it. Fresh clone, fresh build directory, fresh everything.

This is simply impossible. Do these 4 commands work? ``` cd /tmp git clone --recurse-submodules https://github.com/transmission/transmission cmake -S transmission -B transmission.build cmake --build transmission.build --target transmission ``` If they don't,...

Please attach /usr/local/include/libutp/utp.h file here.

Well, needless to say those files shouldn't be there...

I was just pointing someone to 20 ways to break Linux, I guess it applies to Mac too: https://github.com/transmission/transmission/discussions/4951#discussioncomment-5026541

If I were to change how the application is being initialized, I'd rather move `tr_main()` into its own main.cc file, along with `tr_getopt()` use and interop-based delegation, i.e. I'd put...

> I think we can't mix both styles. We don't have to. I'd say this is usually handled by passing `--` argument, i.e. ``` ./transmission-qt -- ``` or vice versa...

Just as an example (untested): https://github.com/transmission/transmission/compare/refactor/qt-main

> Supporting files with `--` in their names is out of scope. The purpose of `--` is generally to avoid false-positives when parsing the arguments, so that passing a torrent...

@H5117, part of this PR is still relevant (e.g. `initUnits()` pointed out by ckerr), might want to rebase or open a new one if you feel up to it.