bt-migrate icon indicating copy to clipboard operation
bt-migrate copied to clipboard
verified publisher icon mikedld

Moderrnize, get rid of boost

Open razaqq opened this issue 4 years ago • 1 comments

  • Use c++20 features like std::filesystem, std::format, std::string_view
  • Get rid of boost and put it where it belongs (the trashcan)

Important note: GCC libstdc++ does not yet have support for std::format, so ideally use Clang libc++ instead

razaqq avatar Oct 28 '21 16:10 razaqq

Looks like C++20 is too recent for this project, unless you want to try and make it work in GitHub Actions. If you do, I'd also appreciate splitting this PR into multiple to ease review (one for filesystem, another for fmt, another for cxxopts, etc.) and using spaces (not tabs) for indentation ;)

Also, I don't really like the idea of having our own implementation of SHA1; will potentially require SHA2 in the future too if BitTorrent v2 is to be supported...

mikedld avatar Oct 31 '21 14:10 mikedld

Most of the changes proposed in this PR are now covered in main so I'm going to close it. If you feel like addressing the rest in more focused PRs, I'd be glad to review them.

mikedld avatar Mar 18 '23 00:03 mikedld