jsDAV icon indicating copy to clipboard operation
jsDAV copied to clipboard

Use jshint, clean up tests r=mikedeboer

Open lambdabaa opened this issue 10 years ago • 3 comments

  • Fixes #103
  • Fixes #104 by configuring jshint and adding make task
  • Fixes #105 by specifying node <0.11 in npm engines

lambdabaa avatar May 28 '14 14:05 lambdabaa

@mikedeboer Can you take a look and also turn on your travis endpoint? See https://travis-ci.org/profile/mikedeboer and toggle the little radio button for mikedeboer/jsDAV

lambdabaa avatar May 28 '14 14:05 lambdabaa

I kind of like the style changes, except the === ones. I understand why it's promoted by JSHint, but we're smart enough to not shoot ourselves in the foot with such obvious things.

I'd actually prefer to take a JSHint configuration that yields as few warnings as possible and work from there.

mikedeboer avatar May 28 '14 22:05 mikedeboer

Sorry if I sound like a jerk, but could you also just revert the == to === changes you made?

Everything else, except the question about the bitwise operator change, looks good to me! Thanks for working on this!

mikedeboer avatar May 29 '14 12:05 mikedeboer