react-pdf-js icon indicating copy to clipboard operation
react-pdf-js copied to clipboard

[feature] Fill parent width

Open Arunscape opened this issue 5 years ago • 2 comments

Hi,

I was looking into making the component fill the parent element. (Being new here), it seems like the library has gone under a pretty big rewrite... (for the better it seems, using TypeScript and hooks and all that good stuff 😍)

Anyways, I looked at the issue #41 and PR #44, and made a super naive/n00b attempt at implementing this functionality:

https://github.com/Arunscape/react-pdf-js/commit/bafa1ce667c18b71aed37a19dcc49a8876f23304

maybe someone who's a bit more experienced can look into actually integrating this, or providing some recommendations 😅 (to be honest, I'm not sure how to test this...)

Arunscape avatar Jun 04 '19 03:06 Arunscape

any update on this?

gabriel-animas avatar Sep 13 '19 22:09 gabriel-animas

the pr is closed and merged but is not in production?

lucasres avatar Aug 20 '20 14:08 lucasres

This should work now. Let me know.

mikecousins avatar Sep 16 '22 04:09 mikecousins