mikechabot
Docker support
Hi: wondered if the project could/should have a Dockerfile by default? Working on one now but just throwing out there in case anyone else has considered.
That'd be great - I don't have much experience with Docker, but I'd gladly accept a PR.
Cool - do you happen to target a specific node version for the boilerplate? Already have a Dockerfile I can PR but would be best to pin to a specific node version.
On Sun, Jan 28, 2018 at 1:46 AM Mike [email protected] wrote:
That'd be great - I don't much experience with Docker, but I'd gladly accept a PR.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mikechabot/react-boilerplate/issues/13#issuecomment-361042377, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFRp7X05NqgqUEfxEF3LqPtkslx-HUiks5tPBfXgaJpZM4RqmVu .
The boilerplate does utilize some ES6 features so targeting >= 6 would be ideal (http://node.green). That said, I've been out of the node loop for a bit (yikes!), and it seems we're up to 9.x and soon to be 10.x in Q2 of this year (https://github.com/nodejs/Release), so I'm open to suggestions wrt whether Docker would benefit from any of the features/perf enhancements from these later versions.
I have sample here. https://gist.github.com/baoduy/9367482e52f192fdaa3d9e489eebed51 Hope it helps.
@baoduy Thanks for the gist. This looks specific to Linux, which is fine, but would a separate docker file be needed for a Windows environment? Please forgive my ignorance of Docker.