Mike Brown

Results 393 comments of Mike Brown

/reopen see comment https://github.com/kubernetes/enhancements/pull/4897#discussion_r1796139509

Hello! see: " FAIL - does not have a valid DCO" All commits must be signed. Suggest setting your git config to have user name and email.. Then git commit...

note to self.. needs feature issue for tracking support of the case.

tagged to 2.0 milestone as Runtime Specific Snapshotters is currently listed to come out of experimental in 2.0 https://github.com/containerd/containerd/blob/main/RELEASES.md#experimental-features

Nod to the this needs to be discussed through the KEP process for k8s.io pod sandboxes... For non k8s.io sandboxes and also for the KEP it would be nice to...

> Is there some operation that needs to be done in a transaction or something? Ideally it wouldn't be possible to introduce an inconsistency between stores that later needs to...

> https://github.com/containerd/containerd/pull/10744 yes fixed in all releases see linked PRs..

> Unrelated, but I feel like the errors in this section are switched: > > https://github.com/containerd/containerd/blob/d20482fea00d2c4ea1ed51aa4a6f2ff1859415c2/internal/cri/server/sandbox_run.go#L221-L227 > > Unless I'm misunderstanding, the first operation should log an `unable to update...