shairport-sync icon indicating copy to clipboard operation
shairport-sync copied to clipboard

Consider replacing alac with ffmpeg due to security issues

Open ehaupt opened this issue 2 years ago • 16 comments

alac has a long list of bugs and security issues. Please consider replacing it with ffmpeg.

This has been prompted by this FreeBSD issue.

ehaupt avatar May 24 '22 05:05 ehaupt

Thanks for the suggestion and the information, Emanuel. As it happens Shairport Sync is just now capable of AirPlay 2 operation on FreeBSD and it is using an ffmpeg AAC decoder, so it should be possible to look at using the ffmpeg ALAC decoder. However, the size of the (libavcodec?) library may be an issue on smaller devices. Once the AirPlay 2 capability is released, I'll look into it.

mikebrady avatar May 24 '22 08:05 mikebrady

Thank you @mikebrady! Maybe both, libavcodec and alac could be made optional (by configure argument). That would leave users and packagers a choice.

ehaupt avatar May 24 '22 08:05 ehaupt

This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

github-actions[bot] avatar Jul 24 '22 02:07 github-actions[bot]

This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

Issue still valid.

ehaupt avatar Jul 24 '22 07:07 ehaupt

This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

github-actions[bot] avatar Sep 23 '22 02:09 github-actions[bot]

Still valid.

m1m1s1ku avatar Sep 23 '22 09:09 m1m1s1ku

This repo seems to have source code fixed to at least some extent:

https://github.com/nu774/qaac/tree/master/ALAC https://perkele.cc/software/ALAC

ehaupt avatar Nov 14 '22 15:11 ehaupt

This issue has been inactive for 45 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

github-actions[bot] avatar Jan 14 '23 01:01 github-actions[bot]

Still valid.

ehaupt avatar Jan 14 '23 08:01 ehaupt

Working (slowly) on stuff associated with this…

mikebrady avatar Feb 13 '23 10:02 mikebrady

Still valid.

ehaupt avatar Apr 27 '23 05:04 ehaupt

It is still relevant.

ehaupt avatar Jul 31 '23 06:07 ehaupt

Yes it is!

mikebrady avatar Jul 31 '23 06:07 mikebrady

This is still active!

mikebrady avatar Dec 22 '23 17:12 mikebrady

Still active!

mikebrady avatar Dec 22 '23 17:12 mikebrady

This issue has been inactive for 28 days so will be closed 7 days from now. To prevent this, please remove the "stale" label or post a comment.

github-actions[bot] avatar Feb 21 '24 00:02 github-actions[bot]