jest-react-hooks-shallow icon indicating copy to clipboard operation
jest-react-hooks-shallow copied to clipboard

Published 20 hours ago • verified publisher icon mikeborozdin

Npm7 & React 17 peer dependency error

Open diego-antonelli opened this issue 3 years ago • 1 comments

Hi,

When trying to use this library with npm7 it fails in combination with react 17.

Is it possible to add rules in the deps to be ^16.8 || ˆ17 in your react deps?

image

diego-antonelli avatar Apr 22 '21 07:04 diego-antonelli

I think the correct solution here would be to add the React dependency as a peerDependency instead of a dependency, together with allowing ^17.0.0. Would that be possible?

@mikeborozdin this seems like a quick change that could be beneficial in cases like this.

joaopsrleal avatar Sep 16 '21 11:09 joaopsrleal