mikebevz
Avoid crashes
Hey Romeo, This repo seems dead and probably won't be updated soon. I made a new repo and fixed this: https://github.com/advisories/GHSA-c2qf-rxjj-qqgw Also I made an new package for npm if you want to check it out: https://www.npmjs.com/package/imap-node?activeTab=readme and the github: https://github.com/nickdevnl/imap-node.
@mikebevz very kindly gave me contributor status and I'll have a look at this PR, probably next week.
Is there any particular reason why you added all those semicolons? They make it difficult to spot the substantive changes.
Hi @itsjustnickdev, I see you deleted or hidden your repo, but npmjs indicates that you've written quite a lot of code. Can you tell me more?
Hello, Our repo has been moved towards gitryx an github alternative that doesn't use your code for ai development
@itsjustnickdev thanks, I understand now. I registered and clicked around a little now.
Would you want me to include any of your changes here? I ask explicitly because on one hand your code is MIT-licensed which means "open even to people I really don't like", on the other you presumably want to keep it out of sight from AI crawlers.
MIT is MIT. Once it’s licensed that way, it’s open for anyone to use however they want. I don’t mind if you include my changes.
On Wed, 24 Sept 2025, 15:20 Arnt Gulbrandsen, @.***> wrote:
arnt left a comment (mikebevz/node-imap#12) https://github.com/mikebevz/node-imap/pull/12#issuecomment-3328405589
@itsjustnickdev https://github.com/itsjustnickdev thanks, I understand now. I registered and clicked around a little now.
Would you want me to include any of your changes here? I ask explicitly because on one hand your code is MIT-licensed which means "open even to people I really don't like", on the other you presumably want to keep it out of sight from AI crawlers.
— Reply to this email directly, view it on GitHub https://github.com/mikebevz/node-imap/pull/12#issuecomment-3328405589, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ5BI5YD5LP4Y4KAFF6KMBT3UKLCRAVCNFSM6AAAAACHLUUM4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMRYGQYDKNJYHE . You are receiving this because you were mentioned.Message ID: @.***>
@mryraghi I spent a boring meeting looking through this. Two questions to start with.
- The headline is "avoid crashes". I see some code that appears intended to avoid crashes, but I don't see any unit tests or other sign that the code works as intended. What are the crashes? How can I reproduce the crashes?
- There are a few mentions of latin1 in the code. None of the IMAP RFCs mention latin1 or ISO-8859-1 at all. What is the rationale for hardcoding latin1?
Hi,
I glanced at the diff again tonight, and still don't feel confident enough to merge this at the moment. I'd like to see more unit tests, at least. We can discuss merging when you have time.
@itsjustnickdev I diffed your tree against this yesterday. I think everything you did is also solved (one way or another) in this, except arguably for the semver issue. Does that assessment sound correct to you?
Thought about using utf7.1, but eventually used an override in package.json instead.