Mike Battista
Mike Battista
Added `App.MainWindow.BringToFront()` in `OnNotificationInvoked` with https://github.com/microsoft/TemplateStudio/pull/4557/commits/31f363869720d42a0bc20261e124ac597cc3f151. Usually this just results in the taskbar icon flashing which is by design behavior for SetForegroundWindow APIs. Open question about if the shell can...
Remaining work here to improve the experience is likely in the platform.
Platform work tracked by https://task.ms/40476788.
Reference project was provided in #4337.
Thanks. I'll move this to the 5.3 release for tracking.
@mrlacey is there a reason for the nested `Directory.GetParent` calls here. I don't see nested calls anywhere else in the project. Might just need to remove the outer call.
This only reproes if the VS checkbox for "solution and project in same directory" is checked.
If I remove the nested GetParent call, the project creation fails later at: https://github.com/microsoft/TemplateStudio/blob/ae61901436e79818adbae678912a01a316b96803/code/SharedFunctionality.Core/PostActions/PostActionFactory.cs#L101 It's trying to enumerate all folders at the root and throwing an exception trying to access...
If that's the case, then we can move it out of the initial VS 2022 milestone yes. We can revisit later.
Thanks for splitting out the testing. That's definitely important and will make the build validation faster and more reliable too. The triggers in the YAML show when they are run....