roll-call
roll-call copied to clipboard
mikeal
Prevent window close if recorded audio is still uploading.
If there's a recording still being uploaded we should try to prevent the user from closing the window if they try.
How about this use case.
A person in poor network tries and audio upload is in progress. He wants to close the browser.
If above feature is implemented, the user won't be close and he will have to wait indefinitely til upload is done..
Is it a valid scenario to be consider?
The browser won't actually let you entirely stop it from closing, the most you can do is present a "are you sure" dialog.
Google Docs handle this quite well, your changes are constantly syncing and if you haven't finished updating the backend and try to close you get a dialog letting you know that you'll lose changes. If you're in sync the dialog is never presented.
Yup, still open ;)
On Friday, October 21, 2016, Williams Omayuku [email protected] wrote:
Hello, I'd like to work on this, if it's still open.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mikeal/roll-call/issues/8#issuecomment-255495235, or mute the thread https://github.com/notifications/unsubscribe-auth/AAACQ09f3siWnbRyNnT2NxBKOeMxtcQgks5q2VomgaJpZM4KRV1d .
@suamorales whatever code you end up putting in to check if the stream is completed, set it to always return false when you want to test the negative case.