roll-call icon indicating copy to clipboard operation
roll-call copied to clipboard

Microphone universal mute ui

Open FotoVerite opened this issue 8 years ago • 2 comments

TODO disable all other cards gains and undisable them on toggle.

FotoVerite avatar Oct 16 '16 15:10 FotoVerite

Nice work @FotoVerite! Looks great, for me at least :)

I would only suggest that you move the mute button to the menu above. Maybe adding a popover or a button label, with mute/unmute text, would help users figuring out that they can mute the entire page. I think it is a bit confusing to have it the audio tile, as mic mutes the user stream and the volume mutes the master output.

Also when creating the menu button, try using funky to create an element. Pass a state parameter that would set the icon colour, and use the update method to toggle it. It is better to use checked and unchecked callbacks from the checkbox plugin to change those states, docs here: http://semantic-ui.com/modules/checkbox.html#/settings.

vladaspasic avatar Oct 16 '16 19:10 vladaspasic

The latest waudio module has a mute() and unmute() method that keep track of the prior volume for us, we should use that.

mikeal avatar Oct 16 '16 20:10 mikeal