Mikeal Rogers

Results 328 comments of Mikeal Rogers

I’m not sure what this accomplishes. Is this meant to convert between the new and old `CID` implementations? If so, this isn’t going to work as stated because what is...

Now that you’re considering a breaking change (deprecating isCID) I should note that there’s a future upgrade to `multiformats` which is also a breaking change to CID, among other things....

@Gozala these answers are a bit complicated, I’m going to join the Core Implementations meeting on Monday and can discuss it in more detail there.

We have this https://github.com/multiformats/js-multiformats#cid, we can extend it to handle this with an example like we talked about or do you feel strongly about having a markdown file in *this*...

*sigh*, `static` isn’t supported widely enough yet. For instance, it’s not in the default eslint grammar which means it isn’t in the default `standard` grammar 😥, so we’ll need to...

We should **not** move to `instanceof` checks. `instanceof` checks can’t be used reliably when handing class instances to third party consumers because the pointer check won’t work if two versions...

> Is that still the case ? In my work I have being defining static class methods and have not seen any complaints from aegir. That’s because `aegir` uses some...

> I understand that and is not what I am suggesting. Ok, sorry for my miss-understanding.

> P.S.: I have being using static getters to work around lack of static properties support. Then the properties aren’t enumerable tho :( which is why I’ve stuck with `Object.defineProperty`...

Can someone point me to what `toV0` is used for? V0 conversion is so limited (`dagpb` only) I’m having a hard time figuring out what this is used for in...