ember-cli-materialize icon indicating copy to clipboard operation
ember-cli-materialize copied to clipboard

Remove all the old components

Open Gorzas opened this issue 4 years ago • 7 comments

Related #774

Gorzas avatar Sep 05 '19 12:09 Gorzas

There were the following issues with this Pull Request

  • Commit: 04acf237450a8eda519ce77e5c6fb08ff5ebb5db
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ghost avatar Sep 05 '19 12:09 ghost

Pls fix the message @Gorzas so this can get merged by @mike-north and people with octane and just use this lol.

ErvinSabic avatar Aug 10 '20 02:08 ErvinSabic

Pls fix the message @Gorzas...

FYI if you don't want to wait you can fork his branch and use git rebase to reword the offending commit messages yourself and create a PR that supersedes this one...

jacobq avatar Aug 11 '20 03:08 jacobq

Can it be merged now?

Gorzas avatar Aug 14 '20 09:08 Gorzas

I'm running into this issue. Is it possible to merge this PR? If not, @Gorzas were you able to find a work around?

chunyinli avatar Feb 22 '21 21:02 chunyinli

@chunyinli I'm currently working from my own fork. I don't know if the PR needs something else to be merge :cry: .

Gorzas avatar Feb 23 '21 07:02 Gorzas

I ended up forking it as well as I needed the fix quickly. Thanks for the reply tho!

chunyinli avatar Feb 23 '21 14:02 chunyinli