ember-cli-materialize icon indicating copy to clipboard operation
ember-cli-materialize copied to clipboard

Shift `sassOptions` in config/environment.js to ember-cli-build.js

Open acorncom opened this issue 10 years ago • 3 comments

Per a deprecation warning thrown by ember-cli-sass, the sassOptions config should now be a part of the ember-cli-build.js file (or the Brocfile.js in older versions of Ember-CLI).

Is this something we can just put in blueprints/ember-cli-materialize/files or will it get more involved? And do we want to be offering to override the ember-cli-build.js when running the add-on installer? Seems like we could run into headaches keeping up ...

I may be able to send in a pull request for this, but thought I'd check what we want to do here first ...

acorncom avatar Sep 21 '15 21:09 acorncom

I think I've seen firebase add a file mutator as to minimize blueprint conflicts which may be useful in this scenario?

rtablada avatar Sep 21 '15 21:09 rtablada

@rtablada Meaning this? https://github.com/firebase/emberfire/blob/master/blueprints/emberfire/index.js#L39-L47

acorncom avatar Sep 21 '15 21:09 acorncom

Yes, I believe a similar thing could be done to add things to ember-cli-build.js

— Sent from Mailbox

On Mon, Sep 21, 2015 at 4:57 PM, David Baker [email protected] wrote:

@rtablada Meaning this? https://github.com/firebase/emberfire/blob/master/blueprints/emberfire/index.js#L39-L47

Reply to this email directly or view it on GitHub: https://github.com/mike-north/ember-cli-materialize/issues/252#issuecomment-142122014

rtablada avatar Sep 22 '15 00:09 rtablada