ember-cli-materialize icon indicating copy to clipboard operation
ember-cli-materialize copied to clipboard

Remove usage of mdi-* icons

Open frankwong15 opened this issue 9 years ago • 3 comments

mdi-* icons are phasing out as per Dogfalo/materialize#1824

To maintain backward compatibility, maybe we can add mdIcon parameter?

{{md-btn text="Button" icon="mdi-action-favorite"}}

to become

{{md-btn text="Button" mdIcon="favorite"}}

and

<i class="mdi-action-favorite"></i>

to become

<i class="material-icons>favorite</i>

frankwong15 avatar Sep 02 '15 13:09 frankwong15

If we add in backward compatibility, I'd like for it to be deprecated immediately. In the future, hopefully everyone will be using the new material-design-icons

mike-north avatar Sep 02 '15 23:09 mike-north

Do we want to remove the icon parameter completely? I think it is handy if someone want to use Font Awesome icon instead.

For example

{{md-btn text="Github" icon="fa fa-github"}}

frankwong15 avatar Sep 03 '15 04:09 frankwong15

Using contextual components allows for some reasonable options w.r.t this, but that'll have to wait for v1.0, since the minimum ember version we need is 2.3.

mike-north avatar Apr 22 '16 20:04 mike-north