node-redlock

node-redlock copied to clipboard

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.6.4 to 4.9.5. Release notes Sourced from typescript's releases. TypeScript 4.9.4 For release notes, check out the release announcement. For the complete list of fixed issues, check...

dependabot[bot]

Stable release when?

1

soryy708

Question about documentation in example snippet

1

https://github.com/mike-marcacci/node-redlock/blob/b720d5fdbe5bb54316031aec8b2c15128dbfa8a9/src/index.ts#L637 Is bullet point (1) actually true? As far as I can tell from the code, the only way the signal gets aborted is if lock extension fails, and the...

jamesblacklock

String script parameter(s) ignored

1

https://github.com/mike-marcacci/node-redlock/blob/b720d5fdbe5bb54316031aec8b2c15128dbfa8a9/src/index.ts#L238 Type signature [above](https://github.com/mike-marcacci/node-redlock/blob/main/src/index.ts#L184) is `string | ((script: string) => string)`, but here the parameter is ignored unless its type is `"function"`.

jamesblacklock

Superfluous type check

1

https://github.com/mike-marcacci/node-redlock/blob/b720d5fdbe5bb54316031aec8b2c15128dbfa8a9/src/index.ts#L731 `instanceof Error` has already been checked [above](https://github.com/mike-marcacci/node-redlock/blob/main/src/index.ts#L723). This check is superfluous.

jamesblacklock

Bumps [@types/ioredis](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/ioredis) from 4.28.10 to 5.0.0. Commits See full diff in compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter...

dependabot[bot]

Hi @mike-marcacci, this appears to be a flavor of request you have received before (i.e. more specific error messaging) but I didn't see this specific request already. Let me know...

awfulstew

Expiration time is in the past

2

**Version:** ^5.0.0-beta.2 When `retryCount` is greater than `0` it is possible to obtain the lock which is already expired. Check the below snippet: ```typescript const lock = await redlock.acquire(['resource'], 1000,...

wombat86

Hello! I noticed a significant difference in logic between the current GitHub source code and the latest release. **Latest release** 1. Storing the timestamp in the `start` variable at the...

kotosha-real

Configure Redis DB # explicitly?

1

How can I choose which Redis DB number is used by node-redlock? I have a perfectly good redis instance I'd like to use for redlock, but I don't want to...

rbonestell