Mike FABIAN

Results 261 comments of Mike FABIAN

Writing into Duolingo using a dark theme in firefox: ![Screenshot](https://user-images.githubusercontent.com/2330175/133002346-d6203363-9500-4e45-8025-8536c8239720.png)

So if I would choose a background colour which looks good in Duolingo, it would look bad when writing the github comments. I think what we actually want is to...

> Maybe, Mike, if we do not **_explicitly_** select a transparent background, Thunderbird and Firefox dark theme will choose the background color that is selected by default. I immediately tried...

Here is why it didn’t help when I tried this yesterday: in `_ibus_context_update_preedit_text_cb ()` in ibus there is: https://github.com/ibus/ibus/blob/master/client/gtk2/ibusimcontext.c#L2037 ``` case IBUS_ATTR_TYPE_FOREGROUND: pango_attr = pango_attr_foreground_new ( ((attr->value & 0xff0000) >>...

https://docs.gtk.org/Pango/func.attr_foreground_new.html https://docs.gtk.org/Pango/func.attr_foreground_alpha_new.html

So at the moment I cannot set the alpha value (i.e. the transparency) from ibus-typing-booster, it is ignored in ibus. To make transparency possible, the code in `_ibus_context_update_preedit_text_cb ()` https://github.com/ibus/ibus/blob/master/client/gtk2/ibusimcontext.c#L2037...

Testing that the transparency is ignored: From the command line, one can set a foreground colour for the inline completion with transparency like this: ``` $ dconf write /org/freedesktop/ibus/engine/typing-booster/colorinlinecompletionstring '"rgba(2...

In `color_string_to_argb(color_string: str) -> int` https://github.com/mike-fabian/ibus-typing-booster/blob/main/engine/itb_util.py#L2525 ibus-typing-booster converts the value `rgba(255,163,72, 0.3)` set above using `dconf` on the command line to a 32 bit integer. For example: ``` >>> print('%x'...

It might be interesting to enhance ibus to allow to use transparency in the colours. Might be a useful improvement. **But** I am not sure whether this would fix the...

To me it also looks like a bug in the dark theme that it uses white as a background colour even though no background colour was set by pango.