phaser-examples-typescript icon indicating copy to clipboard operation
phaser-examples-typescript copied to clipboard

Bringing examples up to date

Open JamesSkemp opened this issue 8 years ago • 5 comments

Given that I'm now feeling half-way decent with using TypeScript and Phaser I was considering helping convert the main examples over to TypeScript.

I noticed that the version of Phaser being used is 2.2.2 (currently at 2.4.4) and that examples have been added and updated in the main project.

Assuming you're good with contributions, do you have a preference on the version of Phaser used, as well as how the examples should be brought up to date?

Some possible ideas:

  1. Do a compare and bring over all changed (new and updated) files. Create an issue for each directory that had TypeScript files created, but which is now out of date. Each file that had been changed would be listed within the issue.
  2. Bring over changed files individually, updating the TypeScript files at the same time. For all directories that weren't converted just bring over the changes.
  3. Re-open closed issues (or recreate) if changes were made. Work on updating and converting directories as part of the existing issue structure (one issue per directory).

Before I spent too much work on getting started, thought I'd check for your thoughts on this.

Thanks!

JamesSkemp avatar Dec 16 '15 22:12 JamesSkemp

Sounds great. And I'm also happy to continue working on this as it's not that big of a deal. The details are fairly easy to translate to TypeScript. I used to hammer in about 3-10 examples in about an hour to two hours into working, solid TypeScript.

Unfortunately the realities hit me once I got a puppy and the rest it history :) Anyhow, to spare you from the details, I'm back on track and could use the hand.

:+1:

mikaturunen avatar Dec 17 '15 05:12 mikaturunen

Heh, I certainly know what that's like.

I still need to wrap my head around how they're pulling in applications/if PHP is really needed or if this is/can be .NET friendly, so ...

I'll probably start but pulling over all the new files, and then pull over updated files that haven't been converted to TS yet.

It's boring and simple, which is the best way to get to know this repo. :)

JamesSkemp avatar Dec 17 '15 11:12 JamesSkemp

Added issues #30, #31, #32, #33, and #34 to account for the completely new example directories.

JamesSkemp avatar Dec 17 '15 13:12 JamesSkemp

Amazing work man! :+1:

mikaturunen avatar Dec 17 '15 13:12 mikaturunen

Happy to help! :D

Remaining items are:

  1. Updating those directories that you've already converted over.
  2. Dealing with the root level and _site file changes (I know what they are, but I don't know enough about these repos yet to feel comfortable committing any of them).

JamesSkemp avatar Dec 17 '15 13:12 JamesSkemp