miglayout icon indicating copy to clipboard operation
miglayout copied to clipboard

Published 20 hours ago • verified publisher icon mikaelgrev

A workaround for JavaFX DPI can (and should) probably be removed

Open utybo opened this issue 7 years ago • 4 comments

The following line should not be present anymore, since the bug has been resolved in the version 8u20 of Java. I did not test this but this line most probably breaks HiDPI compatibility for MigLayout in JavaFX.

https://github.com/mikaelgrev/miglayout/blob/4a7c86769e6e9afe4ee1b5799c8038e73352d0c9/javafx/src/main/java/org/tbee/javafx/scene/layout/MigPane.java#L36

utybo avatar Nov 14 '18 20:11 utybo

Totally agree! It is a patch with quite an impact, influencing other layout managers using DPI as well! Didn't know it was in there. (May explain why my ResponsiveLayout behaves strangely sometimes.)

tbee avatar Nov 15 '18 09:11 tbee

I’m all for removing it. Also note the return of static 96 DPI at the end of the file, which also might be something to fix at the sam time? Important to put info in changes.

mikaelgrev avatar Nov 15 '18 09:11 mikaelgrev

These static 96 should also be removed imo.

https://github.com/mikaelgrev/miglayout/blob/4a7c86769e6e9afe4ee1b5799c8038e73352d0c9/javafx/src/main/java/org/tbee/javafx/scene/layout/MigPane.java#L947

https://github.com/mikaelgrev/miglayout/blob/4a7c86769e6e9afe4ee1b5799c8038e73352d0c9/javafx/src/main/java/org/tbee/javafx/scene/layout/MigPane.java#L956

utybo avatar Nov 15 '18 15:11 utybo

Removed the code, but one test is not running so it stays in 5.3-SNAPSHOT for now

tbee avatar Nov 20 '18 06:11 tbee