node-notifier icon indicating copy to clipboard operation
node-notifier copied to clipboard

Does not seem to work anymore on Electron 11.x

Open jcompagner opened this issue 3 years ago • 2 comments

i get:

error in the main process

resources\app.asar\node_modules\node-notifier\package.json: Unexpected end of JSON Input

and reading up this: https://github.com/electron/electron/issues/18397

it seems that native packages must be Context Aware modules or NAPI ?

jcompagner avatar Nov 18 '20 16:11 jcompagner

For me it's broken as well as of Electron 10, but was working in Electron 8.

laurent22 avatar Nov 28 '20 00:11 laurent22

In fact, at least in some cases you don't need node-notifier on Electron as you can simply use the native browser notifications. If anyone's interested, this is how I've implemented it in my app: https://github.com/laurent22/joplin/commit/849ef418a66689f394be4b6a57413bee8e39ce9d#diff-686a0aacaa9f295468381cf9605f6add22f8b777953753329a60ead828a4f289R67

laurent22 avatar Nov 28 '20 12:11 laurent22