terminal-notifier doesn't exit on app quit (electron)

[apollolux]

Master as of commit 87242c1 (and npm releases before that when terminal-notifier was still a .app) do not exit the terminal-notifier process after an electron app quits. Don't know how much effect this will have on the system yet considering I only just started using master in my electron project and the previous 5.1.2 release version had the memory leaking terminal-notifier, but would like to bring this to your attention anyways.

Is ending the process something I have to handle in my app quit routine, or is it supposed to be handled by node-notifier automatically?

[kurisubrooks]

It's my understanding that the process is spawned when a notification needs to be sent, and is closed when it disappears. I'll file this as a bug while we await information from @mikaelbr

[mikaelbr]

There is no automatic closing of the sub process when the mother process quits. In most cases I don't think this is a problem, when terminal-notifier works properly – but is first noticeable due to the memory leak. If we were to handle this (that is if it's actually a problem), it would have to be handled by node-notifier internally by listening to sigterm and closing sub processes.

[charleskoehl]

the memory leak in terminal-notifier was fixed in v 1.7.2