bacon-love icon indicating copy to clipboard operation
bacon-love copied to clipboard

Excercise 11: Official solution fails due to incorrect test cases

Open Windstalker opened this issue 7 years ago • 2 comments

module.exports = (Bacon, nidelva, leirelva, buttonClicked) =>
        nidelva
            .combine(leirelva, (leirelvaSample, nidelvaSample) => leirelvaSample + nidelvaSample)
            .sampledBy(buttonClicked);

✓ Should return an event stream ✓ Should make an EventStream from samples with the sum of the two rivers on click ✗ Should emit values every time button is clicked and give the sum of the two rivers on click

It seems last test expects return of Property, but not EventStream.

module.exports = (Bacon, nidelva, leirelva, buttonClicked) =>
        nidelva
            .combine(leirelva, (leirelvaSample, nidelvaSample) => leirelvaSample + nidelvaSample)
            .sampledBy(buttonClicked) 
            .toProperty();

Windstalker avatar Nov 15 '16 08:11 Windstalker

Hi. Thanks for the issue. It doesn't really expect a property as far as I can see (or remember), so there might be something else happening here. Needs to be investigated some.

mikaelbr avatar Nov 15 '16 11:11 mikaelbr

I cannot reproduce this bug, my version runs fine:

module.exports = (Bacon, nidelva, leirelva, buttonClicked) => {
  const combinedLevels = nidelva.combine(leirelva, (a, b) => a + b);
  return combinedLevels.sampledBy(buttonClicked);
};

adrianmcli avatar Jan 06 '17 03:01 adrianmcli