Added hashtags highlighting to Tweet card body

Open Mcrich23 opened this issue 3 years ago • 6 comments

Progress on issue #82

Having an issue where it duplicates hashtags though.

Mar 28 '22 07:03 Mcrich23

If you're having an issue, no need to make a PR yet, you can comment on the issue!

Mar 28 '22 12:03 mikaelacaron

Ok. Thx

Mar 28 '22 15:03 Mcrich23

Ready for review

Mar 31 '22 23:03 Mcrich23

Made those fixes

Apr 01 '22 02:04 Mcrich23

@mikaelacaron I removed the edge case stuff

Apr 06 '22 14:04 Mcrich23

@Mcrich23 There is a bug still, and I would like to resolve this one before merging: Add this tweet to Brain Marks: tweet See how the word line is highlighted it's because everything is separated by spaces but the hashtag is actually separated by line breaks: livestream\n\n#Xcode So all of livestream and #Xcode are getting highlighted, See @ByCyril 's response

Apr 09 '22 02:04 mikaelacaron