Basic-Car-Maintenance icon indicating copy to clipboard operation
Basic-Car-Maintenance copied to clipboard
verified publisher icon mikaelacaron

FEATURE - Write a New Unit Test

Open mikaelacaron opened this issue 1 year ago • 5 comments

Describe the feature you want the app to have that it currently doesn't

  • Write a new unit test for something in the app, and possibly also do some research about if there's anything extra needed when using the Firebase emulator and unit tests

Describe alternatives you've considered

N/A

Additional context

this change should be less than 300 lines of code, so it's not modifying the whole architecture to make it testable, that's very difficult and causes issues and conflicts for others, instead look for something that can be unit tested in the app right now

mikaelacaron avatar Oct 23 '24 06:10 mikaelacaron

I'd like to work on this and write some tests for OdometerViewModel.

lauriecai avatar Feb 23 '25 17:02 lauriecai

@lauriecai awesome!! can you make a new issue on what specifically you'd like to test? let me know any challenges you see about testing the code (I know it's not in amazing shape right now for that, but hopefully that can change).

Also please use the new Swift Testing framework

mikaelacaron avatar Feb 24 '25 00:02 mikaelacaron

@mikaelacaron Here's the issue: #379 and PR: #380. This is my first time contributing and navigating the workflow. What type of comments go on the issue versus the PR itself? I included everything in the PR.

lauriecai avatar Feb 26 '25 19:02 lauriecai

@lauriecai great thank you! I'll comment on those specifically and let you know!

mikaelacaron avatar Mar 02 '25 15:03 mikaelacaron

@tathagatgaikwad22 your PR was marked as spam due to it all being in python and this is an iOS and Swift project

mikaelacaron avatar Oct 07 '25 23:10 mikaelacaron