templight icon indicating copy to clipboard operation
templight copied to clipboard

Published 20 hours ago • verified publisher icon mikael-s-persson

Compilation issues : getFileName and endianness

Open JeWaVe opened this issue 1 year ago • 3 comments

in file include/ThinProtobuf.h:225 (for example), llvm::support::endianness doesn't exist. It seems to be llvm::endianness that should be used instead. See : https://llvm.org/doxygen/namespacellvm.html#ae1e26e57357947b25e392fd18ab000db

in lib/TemplightTracer.cpp:200 and lib/TemplightAction.cpp:59, getFileName doesn't exist. It seems that tryGetRealPathName should be used instead.

JeWaVe avatar Jan 26 '24 11:01 JeWaVe

patch-issue-95.tar.gz Here is a patch fixing the issue

JeWaVe avatar Jan 26 '24 11:01 JeWaVe

@JeWaVe I'm not involved with this project, but I'd guess the best chance of landing this patch would be to make a pull request rather than posting a tar.gz

asomerville-latai avatar Jul 01 '24 17:07 asomerville-latai

Actually it looks @mikael-s-persson fixed this so this can probably be closed as fixed.

Fixed here: https://github.com/mikael-s-persson/templight/commit/beed5335cd6f957eaff7254f3566d9755a1aa1bb

asomerville-latai avatar Jul 01 '24 17:07 asomerville-latai