napi-thread-safe-callback icon indicating copy to clipboard operation
napi-thread-safe-callback copied to clipboard

Crash while deleting ThreadSafeCallback::Impl on OSX Big Sur

Open enami opened this issue 3 years ago • 2 comments

An electron application which uses @abandoneware/noble (and noble itself uses this napi-thread-safe-callback) crashes when an application exits on OSX Big Sur.

Here is a issue reported in noble repository: https://github.com/abandonware/noble/issues/215

I've submitted a PR which uses thread-safe-function instead, but a maintainer of noble wants to be fixed in napi-thread-safe-callback: https://github.com/abandonware/noble/pull/219#issuecomment-896565975

So, I've opened this issue. How do you think?

enami avatar Aug 18 '21 03:08 enami

In my opinion this project should be considered deprecated and replaced with napi native functionality, like you did. So while I did not review your changes, switching to napi and ditching this module is the right thing to do in principle.

I don't know how to properly fix this problem in this project, and I won't be able to spend time on either. I'll accept pull requests of course.

But the better course of action is to ditch this and use napi directly.

mika-fischer avatar Aug 25 '21 19:08 mika-fischer

If project is deprecated maybe could it be transferred to @abandonware org :

Relate-to: https://rzr.github.io/rzr-presentations/docs/abandonware/#

rzr avatar Sep 25 '21 23:09 rzr