mihon
mihon copied to clipboard
mihonapp
Change feature when touch a manga author's name
Describe your suggested feature
Like tag's interactive, allow me to search in library or copy into cache I'd like that take place to author name's interactive
Other details
No response
Acknowledgements
- [X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
- [X] I have written a short but informative title.
- [X] I have updated the app to version 0.16.5.
- [X] I will fill out all of the requested information in this form.
This already exists though? Quickly tap the author name to start a search, long tap to copy it to your clipboard.
Or do you mean something else?
yes i mean when i quickly tap the author name to start a search but in my library not in all available extension. something work like when i tap to the manga's tag.
Please do not show source names here.
Anyway, couldn't you just use the copy name functionality and then paste that into the library search? That'd be approximately 3-4 taps total.
Please do not show source names here.
Anyway, couldn't you just use the copy name functionality and then paste that into the library search? That'd be approximately 3-4 taps total.
Ok i'll fix that source. Get to the point, i used to search the author in my library very often cause u know (its h3nt author n i have about 10k manga with so many authors :)). hope someone can add this feature, i can wait to the next version of Mihon when the dev ready to upgrade it.
Many websites have special urls for the author searches. Perhaps when short tapping the author Textview a search with a special author filter could be performed instead of a simple search query. This way the search would include more and better results in case the authors name wasnt in the title.
Anyway, couldn't you just use the copy name functionality and then paste that into the library search? That'd be approximately 3-4 taps total.
Would be more intuitive and quicker if the short press would be changed.
The problem lies in how all sorts of sources use all sorts of different ways to search for authors, ranging from url encoding the name all the way to assigning each author a UUID, and to my knowledge, Mihon doesn't have these values available.
Using an author filter on a search is also not guaranteed to be compatible with even most sources. They might not support author search or even filtered search to begin with, meaning the short press functionality change you're suggesting would become useless for those sources that can't use it. And making the short press behave differently for different sources is just a usability, maintenance, and support nightmare.
making the short press behave differently for different sources is just a usability, maintenance, and support nightmare.
But if you click on the tags below the description you can search for a specific genre on the extension, so instead of the search query being set to the genre string the filter will be adjusted. So we would just have to do the exact same...
After browsing through the source code I noticed the genre search function is quite messily implemented. All the filters of the source are being searched through for a Filter.Group or Filter.Select class which is then assumed to be containing the genres (See BrowseSourceScreenModel.kt:174). Its a bit sad there is no default schema for some important filters like genres or authors. But maybe it might be possible to follow after the example of the genre implementation and simply search for Filter.Text type with the "Author", "Authors" or "Artist", "Artists" name and if no such field is found fallback to normal search?
They might not support author search or even filtered search to begin with
I believe if the extension returns a FilterList in the getFilterList() method it should be able to filter by it since it also shows up in the BrowseSourceScreen then.
For those extensions that use UUIDs for authors a workaround could be thought out like caching a map from the author string to the uuid in the extension when the manga is to be parsed and use it when clicking on the author. If the free author search function would be too unreliable that is.
A problem might be that we would abandon the global search window if we only search in the current extension by author. This could be rectified by using the button on the extension overview though.
Although another option would be to rather than implementing changes to the author button functionality, to add an author tag within the extension perhaps prepended by a special string like author: