mihon icon indicating copy to clipboard operation
mihon copied to clipboard

When I download 40 chapter or more it start to become slow

Open ZoMpziO opened this issue 1 year ago • 6 comments

Steps to reproduce

I'm reading Martial Peak and have a lot of chapters and when I start downloading about 100 chapter it took about 5 minutes to just start downloading and the number of time is increasing the more chapters i download and when it start downloading the app start to lag

Expected behavior

Run normally

Actual behavior

the app start to lag

Crash logs

mihon_crash_logs.txt

Mihon version

App version: 0.16.5

Android version

Android 10

Device

Huawei y7p

Other details

No response

Acknowledgements

  • [X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • [X] I have written a short but informative title.
  • [X] I have gone through the FAQ and troubleshooting guide.
  • [X] I have updated the app to version 0.16.5.
  • [X] I have updated all installed extensions.
  • [X] I will fill out all of the requested information in this form.

ZoMpziO avatar Apr 28 '24 22:04 ZoMpziO

The app doesn't start to lag, the extension is rate limiting to save you from your naive self. It is slowing down so you won't get banned from the source and then you won't be able to read your manhwa at all. There is a reason the app gives you a warning when downloading large amounts.

Norsze avatar Apr 28 '24 22:04 Norsze

This issue description reads like that old joke:

Patient walks into doctor's office - Patient: Hey doc, it hurts when I do this *stabs himself* - Doctor: Then don't do it

BrutuZ avatar Apr 28 '24 23:04 BrutuZ

It sounds similar to #705

FooIbar avatar Apr 29 '24 05:04 FooIbar

The app doesn't start to lag, the extension is rate limiting to save you from your naive self. It is slowing down so you won't get banned from the source and then you won't be able to read your manhwa at all. There is a reason the app gives you a warning when downloading large amounts.

This is false, and inappropriately blames the user for what is actually a bug in the software. Please see https://github.com/mihonapp/mihon/issues/705 for a technical analysis of what is really going on.

raxod502 avatar Apr 30 '24 02:04 raxod502

The app doesn't start to lag, the extension is rate limiting to save you from your naive self. It is slowing down so you won't get banned from the source and then you won't be able to read your manhwa at all. There is a reason the app gives you a warning when downloading large amounts.

This is false, and inappropriately blames the user for what is actually a bug in the software. Please see https://github.com/mihonapp/mihon/issues/705 for a technical analysis of what is really going on.

I did, though I will still argue that a user downloading 1000 downloads is a problem. And it is not a behaviour that should be encouraged, aka you are a partial problem

Norsze avatar Apr 30 '24 02:04 Norsze

We may be able to close this as a duplicate of https://github.com/mihonapp/mihon/issues/705, since I believe the reported problem (that UI performance suffers when initiating downloads) is the same. The original poster can correct me if I've misunderstood their report.

Of course, nobody expects that downloading a large number of chapters should be fast, because appropriate rate limiting should be applied in order to avoid placing unacceptable load on upstream providers - and Mihon does indeed apply such rate limiting - but certainly adding a large number of chapters to the download queue should be fast as it is a purely local operation, and certainly adding chapters to the download queue should not have run-on effects on device CPU utilization nor interface responsivity, as reported in https://github.com/mihonapp/mihon/issues/705#issuecomment-2079290042.

So, I think the only change that need be made here is to fix the filesystem performance degradation, and that is covered adequately in https://github.com/mihonapp/mihon/issues/705, hence my suggestion to close as duplicate.

raxod502 avatar Apr 30 '24 03:04 raxod502

Closing in favor of #705 which addresses the core issue

AntsyLich avatar May 04 '24 10:05 AntsyLich