mihon icon indicating copy to clipboard operation
mihon copied to clipboard

Swipe Back doesnt Have Animation

Open kazuhachuli opened this issue 2 years ago • 13 comments

Steps to reproduce

1.- Open Mihon 2.- You are at library 3.- Swipe back with gesture(right to left or left to right) to go at Home (Android Desktop) 4.- When i swipe back the animation doesnt appear

Expected behavior

There should be an animation when you swipe back to go home.

Actual behavior

There is no animation when there should be

Crash logs

No response

Mihon version

0.16.0

Android version

Android 13

Device

Poco X3 Pro MIUI 14

Other details

In Tachiyomi 0.14.7 this error doesnt occur but in 0.15 yes When you swipe from bottom to top the animation works only doesnt appear when you swipe right to left or left to right

Acknowledgements

  • [X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • [X] I have written a short but informative title.
  • [X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
  • [X] I have gone through the FAQ and troubleshooting guide.
  • [X] I have updated the app to version 0.15.3.
  • [x] I have updated all installed extensions.
  • [X] I will fill out all of the requested information in this form.

kazuhachuli avatar Jan 16 '24 14:01 kazuhachuli

Not an app issue. Works fine for me.

Xori71 avatar Jan 16 '24 16:01 Xori71

For some devices works fine, I don't understand why it doesn't work, for Tachiyomi 0.14.7 works fine but after code refactoring at Tachiyomi 0.15.0 doesnt work :( same for Mihon 0.16.0

kazuhachuli avatar Jan 16 '24 16:01 kazuhachuli

I get your frustration, but your situation is very specific.

Provide more information to the devs, such as your device name, Android skin (if you are running one), etc.

Xori71 avatar Jan 16 '24 16:01 Xori71

Device: M2102J20SG Android ver: 13 MIUI ver: 14 Idk what is Android skin, if it means custom rom, i dont have custom rom

kazuhachuli avatar Jan 16 '24 16:01 kazuhachuli

Device: M2102J20SG Android ver: 13 MIUI ver: 14 Idk what is Android skin, if it means custom rom, i dont have custom rom

An Android skin is software running on top of AOSP that OEMs implement on their devices. MIUI, which you seem to have, is one of them.

Xori71 avatar Jan 16 '24 16:01 Xori71

Then i have MIUI, I specified that in my first message. It's exasperating that this happens to me honestly, possibly it was because of the refactoring code at 0.15.0

kazuhachuli avatar Jan 16 '24 16:01 kazuhachuli

Check the preview build of Mihon to see if the issue is still present or not.

On Tue, Jan 16, 2024, 18:18 kazuhachuli @.***> wrote:

Then i have MIUI, I specified that in my first message. It's exasperating that this happens to me honestly, possibly it was because of the refactoring code at 0.15.0

— Reply to this email directly, view it on GitHub https://github.com/mihonapp/mihon/issues/34#issuecomment-1894070678, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYETDRUFTYLCQ67MEPPVXQTYO2R5HAVCNFSM6AAAAABB45QHKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGA3TANRXHA . You are receiving this because you commented.Message ID: @.***>

Xori71 avatar Jan 16 '24 16:01 Xori71

Not work at Mihon Preview r6442

kazuhachuli avatar Jan 16 '24 16:01 kazuhachuli

I see. Antsy will probably see the report, so exercise patience for the time being.

On Tue, Jan 16, 2024, 18:35 kazuhachuli @.***> wrote:

Not work at Mihon Preview r6442

— Reply to this email directly, view it on GitHub https://github.com/mihonapp/mihon/issues/34#issuecomment-1894102594, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYETDRQDRQLRABBH42QN5M3YO2T5FAVCNFSM6AAAAABB45QHKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGEYDENJZGQ . You are receiving this because you commented.Message ID: @.***>

Xori71 avatar Jan 16 '24 16:01 Xori71

Okie :) thank you

kazuhachuli avatar Jan 16 '24 16:01 kazuhachuli

Okie :) thank you

No problem.

Xori71 avatar Jan 16 '24 17:01 Xori71

Works find on my device Samsung S9 Android 10 One UI version 2.5

@kazuhachuli make sure in developer mode you haven't turned off animation also check if animation works on other apps. it'll be helpful if you can screen record your issue and attach it here

OmarShezan avatar Jan 18 '24 12:01 OmarShezan

Animations are activated, it is an app problem, when you swipe from bottom to top the animation works only doesnt appear when you swipe right to left or left to right

kazuhachuli avatar Jan 18 '24 19:01 kazuhachuli

@kazuhachuli could you provide a video of the issue? It seems to work fine here.

theolm avatar Jan 29 '24 00:01 theolm

@kazuhachuli could you provide a video of the issue? It seems to work fine here.

https://github.com/mihonapp/mihon/assets/59351873/c00e64a4-cc1f-42b1-ae69-51a47819585f

kazuhachuli avatar Jan 29 '24 08:01 kazuhachuli

It's a known issue with predictive back on Android 13-based MIUI. One solution is to disable predictive back on Android 13.

FooIbar avatar Jan 30 '24 08:01 FooIbar

I dont have predictive back activated at developer options, its disabled. Also in other apps works fine

kazuhachuli avatar Jan 30 '24 09:01 kazuhachuli

I dont have predictive back activated at developer options, its disabled. Also in other apps works fine

That's the problem. It's broken even with predictive back disabled in developer options if the app has enableOnBackInvokedCallback=true.

One solution is to disable predictive back on Android 13.

I was talking about disable it on the app side.

FooIbar avatar Jan 30 '24 09:01 FooIbar

How can i disable on app side?

kazuhachuli avatar Jan 30 '24 12:01 kazuhachuli

Oh well, I think you mean the developers change it, patience and wait i think

kazuhachuli avatar Jan 30 '24 12:01 kazuhachuli

Won't/Can't fix. Rational: https://github.com/mihonapp/mihon/pull/288#issuecomment-1918915444

AntsyLich avatar Jan 31 '24 11:01 AntsyLich