mihon icon indicating copy to clipboard operation
mihon copied to clipboard

Can't delete chapter in a excluded category

Open vampdx opened this issue 1 year ago • 3 comments

Steps to reproduce

  1. Create a category
  2. In Settings->Downloads->Delete Chapters, add category to "excluded categories"
  3. Add a manga to excluded category
  4. Download a chapter
  5. Manually delete chapter

Expected behavior

I expect the setting to only deactivate automatic delete of read chapters and not a manuel delete as well.

Actual behavior

Chapter is kept instead of deleted

Crash logs

No response

Mihon version

0.16.5

Android version

Android 14

Device

Xiaomi 13T

Other details

No response

Acknowledgements

  • [X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • [X] I have written a short but informative title.
  • [X] I have gone through the FAQ and troubleshooting guide.
  • [X] I have updated the app to version 0.16.5.
  • [X] I have updated all installed extensions.
  • [X] I will fill out all of the requested information in this form.

vampdx avatar Oct 07 '24 22:10 vampdx

I expect the setting to only deactivate automatic delete of read chapters and not a manuel delete as well.

Why would you expect that? The section is named "Delete chapters" not "Auto-delete Chapters"

BrutuZ avatar Oct 07 '24 23:10 BrutuZ

Because I don't see a reason to lock deletes if there are no auto deletes set. Without that setting you just have to do nothing to not delete a chapter. But I am willing to adjust my expectations with a example why you would block deletes without auto deletes

vampdx avatar Oct 08 '24 09:10 vampdx

But I am willing to adjust my expectations with a example why you would block deletes without auto deletes

So you don't accidentally delete it?

AntsyLich avatar Oct 08 '24 14:10 AntsyLich

@vampdx got a counter argument? or should i close the issue.

AntsyLich avatar Oct 14 '24 07:10 AntsyLich

Bug can be closed. I see my expectations were wrong even if I don't really see the need for a delete lock

vampdx avatar Oct 14 '24 10:10 vampdx