JCSG icon indicating copy to clipboard operation
JCSG copied to clipboard

Published 20 hours ago • verified publisher icon miho

Fix the stackOverflow issue in #54

Open madhephaestus opened this issue 3 years ago • 5 comments

This is a fix to the stack overflow issue in the plane split function. If a plane that comes in that is not as flat as the fixed Plane.EPSILON value, then the algorithm would recourse until a crash.

This change measures the epsilon off of the incoming polygon to set the epsilon values accurately for each incoming polygon.

madhephaestus avatar Mar 25 '21 21:03 madhephaestus

@madhephaestus When I enable this the icosahedron.intersect assert of the IcosahedronTest fails

CreamyCookie avatar Mar 12 '23 16:03 CreamyCookie

This feature should be implemented in neuronrobotics/jcsg along with lots of additional features. I made this pr in hopes the upstream project was not abandoned, but alas, it seems the neuronrobotics fork seems to the the currently maintained fork.

madhephaestus avatar Mar 12 '23 16:03 madhephaestus

@madhephaestus Oh, maybe I should have mentioned.. I applied the changes to your fork, and there the test failed.

CreamyCookie avatar Mar 22 '23 18:03 CreamyCookie

My fork already has this feature. This PR is intended to back-feed solutions to begs to the ubstream project, in case someone is stock on this fork for some reason. There is no need to apply this to my fork.

madhephaestus avatar Mar 23 '23 20:03 madhephaestus

@madhephaestus Ah, I see, my bad

Thank you for your fork :+1:

CreamyCookie avatar Apr 02 '23 14:04 CreamyCookie