node-directory-tree icon indicating copy to clipboard operation
node-directory-tree copied to clipboard

Test failed on Windows

Open rattanakchea opened this issue 7 years ago • 3 comments

On my Windows, the npm run test failed, because file size does not match.

rattanakchea avatar Aug 15 '18 21:08 rattanakchea

@rattanakchea do you think you can make a cross-platform fix for it? Thanks!

mihneadb avatar Aug 24 '18 06:08 mihneadb

Since file sizes on Windows, Mac or other OS can very slightly. It is no one test fit all.

My suggestion would be remove file size when testing? Any other suggestion?

rattanakchea avatar Aug 25 '18 00:08 rattanakchea

Sounds good. It should still test that size is present, just not check its value, I guess.

mihneadb avatar Aug 25 '18 12:08 mihneadb