Video-Chat icon indicating copy to clipboard operation
Video-Chat copied to clipboard

Added Dark/Light Toggle

Open SubhamKarmakar24 opened this issue 3 years ago • 16 comments

Closes #17

Changes made:

  • Addition of Dark mode toggle button
  • The preferred theme that the user has chosen is saved in cache. So, the next time the user opens the website, the preferred theme is already applied.

SubhamKarmakar24 avatar Oct 02 '21 07:10 SubhamKarmakar24

Someone is attempting to deploy a commit to a Personal Account owned by @mihir0699 on Vercel.

@mihir0699 first needs to authorize it.

vercel[bot] avatar Oct 02 '21 07:10 vercel[bot]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

video-mihir – ./client

🔍 Inspect: https://vercel.com/mihir0699/video-mihir/AThmN6z3Si2R6dmeoitbP5jUfq7M
✅ Preview: https://video-mihir-git-fork-subhamkarmakar24-main-mihir0699.vercel.app

vercel[bot] avatar Oct 02 '21 07:10 vercel[bot]

Closes #17

Changes made:

* Addition of Dark mode toggle button

* The preferred theme that the user has chosen is saved in cache. So, the next time the user opens the website, the preferred theme is already applied.

@mihir0699 I have implemented the Dark mode toggle button. Could you please review the code?

SubhamKarmakar24 avatar Oct 02 '21 07:10 SubhamKarmakar24

Hello @SubhamKarmakar24 , thanks a lot for the contribution, adding theme toggle is a great feature, your PR was deployed using vercel here- https://video-mihir-git-fork-subhamkarmakar24-main-mihir0699.vercel.app, I have reviewed the changes and great job is done by you, however I would like you to fix some CSS issue before we can go ahead and merge it image

Can you notice the contrast issues here?

Also in light mode the background that was used to before is not in place, please fix that

mihir0699 avatar Oct 02 '21 07:10 mihir0699

Hello @SubhamKarmakar24 , thanks a lot for the contribution, adding theme toggle is a great feature, your PR was deployed using vercel here- https://video-mihir-git-fork-subhamkarmakar24-main-mihir0699.vercel.app, I have reviewed the changes and great job is done by you, however I would like you to fix some CSS issue before we can go ahead and merge it image

Can you notice the issues here?

Also in light mode the background that was used to before is not in place, please fix that

Yes, I would fix them. Regarding the input box, it seems that the library that is used(Ant Design) do not support changing the color of Modal, Input Box and Buttons dynamically. I read their documentation and I could not find a set style attribute that changes the colors. So there is an option of completely changing the library or leave the modal and input boxes as it is now.

The other changes(such as the text and the background color) will be fixed in a moment.

SubhamKarmakar24 avatar Oct 02 '21 07:10 SubhamKarmakar24

Hello @SubhamKarmakar24 , thanks a lot for the contribution, adding theme toggle is a great feature, your PR was deployed using vercel here- https://video-mihir-git-fork-subhamkarmakar24-main-mihir0699.vercel.app, I have reviewed the changes and great job is done by you, however I would like you to fix some CSS issue before we can go ahead and merge it image Can you notice the issues here? Also in light mode the background that was used to before is not in place, please fix that

Yes, I would fix them. Regarding the input box, it seems that the library that is used(Ant Design) do not support changing the color of Modal, Input Box and Buttons dynamically. I read their documentation and I could not find a set style attribute that changes the colors. So there is an option of completely changing the library or leave the modal and input boxes as it is now.

The other changes(such as the text and the background color) will be fixed in a moment.

Okay, do let me know when you are done with the changes, will review it

mihir0699 avatar Oct 02 '21 07:10 mihir0699

Okay, do let me know when you are done with the changes, will review it

@mihir0699 I have fixed the text color in dark mode, fixed the background color in light mode to original.

SubhamKarmakar24 avatar Oct 02 '21 08:10 SubhamKarmakar24

Okay, do let me know when you are done with the changes, will review it

@mihir0699 I have fixed the text color in dark mode, fixed the background color in light mode to original.

Thanks for making the changes, but can you please find a workaround for the input field and button color in dark mode, it does not stands good with the dark mode, rest all looks good now

mihir0699 avatar Oct 02 '21 09:10 mihir0699

Okay, do let me know when you are done with the changes, will review it

@mihir0699 I have fixed the text color in dark mode, fixed the background color in light mode to original.

Thanks for making the changes, but can you please find a workaround for the input field and button color in dark mode, it does not stands good with the dark mode, rest all looks good now

Okay, I am trying to use pure HTML, CSS components to make the input boxes. Hope it will work

SubhamKarmakar24 avatar Oct 02 '21 09:10 SubhamKarmakar24

Thanks for making the changes, but can you please find a workaround for the input field and button color in dark mode, it does not stands good with the dark mode, rest all looks good now

@mihir0699 Fixed the input background color

SubhamKarmakar24 avatar Oct 02 '21 10:10 SubhamKarmakar24

Thanks for making the changes, but can you please find a workaround for the input field and button color in dark mode, it does not stands good with the dark mode, rest all looks good now

@mihir0699 Fixed the input background color

Will review it soon

mihir0699 avatar Oct 02 '21 13:10 mihir0699

Will review it soon

Thanks

SubhamKarmakar24 avatar Oct 02 '21 13:10 SubhamKarmakar24

Hello @SubhamKarmakar24 , I have reviewed the changes, the input field issue is also fixed well done, but the chat window colors are not in sync with the theme, can you pls take a look and do the required changes?

mihir0699 avatar Oct 02 '21 16:10 mihir0699

Hello @SubhamKarmakar24 , I have reviewed the changes, the input field issue is also fixed well done, but the chat window colors are not in sync with the theme, can you pls take a look and do the required changes?

Sure, will look into it

SubhamKarmakar24 avatar Oct 02 '21 16:10 SubhamKarmakar24

Hello @SubhamKarmakar24 , I hope you are working on this right?

mihir0699 avatar Oct 07 '21 08:10 mihir0699

Hello @SubhamKarmakar24 , I hope you are working on this right?

I tried, but the animations of opening and closing the modal are difficult to replicate.

SubhamKarmakar24 avatar Oct 07 '21 13:10 SubhamKarmakar24