Miheer Salunke comments

Results 16 comments of


                                            Miheer Salunke

NE-1516: Adds a field in the cluster ingress config object and Ingress Controller to set EIP via installer and Ingress Controller

@gcs278 @JoelSpeed PTAL. I have made the changes.

NE-1516: Adds a field in the cluster ingress config object and Ingress Controller to set EIP via installer and Ingress Controller

@JoelSpeed @gcs278 PTAL

NE-1516: Adds a field in the cluster ingress config object and Ingress Controller to set EIP via installer and Ingress Controller

@JoelSpeed @gcs278 i have added some CELs please take a look.

NE-1516: Adds a field in the cluster ingress config object and Ingress Controller to set EIP via installer and Ingress Controller

> changes > There are quite a few outstanding comments on this PR from previous reviews, as well as some that are fixed but not resolved, can we try to...

NE-1516: Adds a field in the cluster ingress config object and Ingress Controller to set EIP via installer and Ingress Controller

@gcs278 @JoelSpeed PTAL I have made the changes.

NE-1516: Adds a field in the cluster ingress config object and Ingress Controller to set EIP via installer and Ingress Controller

@gcs278 @JoelSpeed PTAL I have also removed the config/v1 part as the installer part of this epic is not doable this time so not including the config/v1 this time.