vuiet icon indicating copy to clipboard operation
vuiet copied to clipboard

vuiet uses ivy without a package dependency on it

Open catern opened this issue 2 years ago • 1 comments

If I package-install vuiet, then vuiet-play-album and hit tab, I get an error about missing ivy functions. So I had to explicitly package-install ivy as well. vuiet should depend on ivy if it uses it automatically.

Related also to #15; vuiet could avoid depending on ivy if it used the emacs completion interface (info "(elisp) Completion") instead of hardcoding ivy.

catern avatar Feb 19 '22 16:02 catern

Definitely something to consider. I haven't used completing-read myself nor is this on my high-prio tasks at the moment.

Accepting PRs.

mihaiolteanu avatar Feb 23 '22 12:02 mihaiolteanu

I agree that completing-read would be great, but I think as a minimum Vuiet should depend on Ivy on install, since it does depend on it to run.

thriveth avatar Dec 18 '23 23:12 thriveth

Updated. Thanks for bumping this up!

mihaiolteanu avatar Dec 19 '23 09:12 mihaiolteanu