Mihai Maruseac
Mihai Maruseac
#411 adds support for PKCS11. I need to review, but more eyes on it would also help.
+1 to having these after v1, for v1 we should have 1 end-to-end sign and verify flow and everything else is bonus
I think we need to wait at least until end of this year. Python 3.12 was released only last October.
We'll wait until 3.11 becomes end of line officially.
We don't block issues on who declares to work on them, we just look at the PRs. Please feel free to work on it and I'm looking forward to the...
Awesome. Please see #293 and #295 as starting points, as those were made to make the test coverage visible in the PR review, something very similar to this.
Oh, for sure! Thank you
Right now we are indeed comparing manifest form signature with manifest from local model, but we are planning to support partial verification. It is somewhat captured in #160 and https://github.com/sigstore/model-transparency/blob/621211a1e91b396e6335be576da9e3698d456311/src/model_signing/manifest.py#L31-L35
Thank you for the report. I managed to reproduce this. It's a high priority issue to fix, let me see if I can find some time.
We now have ability to sign models with Sigstore, please see https://github.com/google/model-transparency/tree/main/model_signing#onnx Currently we're incubating this, testing to see if things are working properly, if all supported models work, etc....