dephpend icon indicating copy to clipboard operation
dephpend copied to clipboard

Published 20 hours ago • verified publisher icon mihaeu

Support installation on PHP 8

Open szepeviktor opened this issue 3 years ago • 5 comments

szepeviktor avatar May 02 '21 14:05 szepeviktor

Coverage Status

Coverage remained the same at 100.0% when pulling 9b21d756932b31f865e7fdb0c8b389fd2b84f322 on szepeviktor:patch-2 into 2ecf0ebb661c9e0ba25f49f05ab0a6849600f9ec on mihaeu:main.

coveralls avatar May 02 '21 14:05 coveralls

❌ https://travis-ci.org/github/mihaeu/dephpend/jobs/769221898

  1. Mihaeu\PhpDependencies\Analyser\XDebugFunctionTraceAnalyserTest::testThrowsExceptionIfFileCannotBeOpened

Failed asserting that exception of type "ValueError" matches expected exception "InvalidArgumentException".

Please help me.

szepeviktor avatar May 02 '21 14:05 szepeviktor

Hey @szepeviktor so you want to both test PHP 8 code and execute dephpend from PHP 8. Makes sense :sweat_smile:

Before I jump on this: apart from the failing test does everything else seem to work with PHP 8?

mihaeu avatar May 02 '21 14:05 mihaeu

Before I jump on this: apart from the failing test does everything else seem to work with PHP 8?

⚠️ I do not have PHP 8 and there is no developer on my side :)

I think there is not. I'm not a dephpend user! Please see https://travis-ci.org/github/mihaeu/dephpend/jobs/769221898

szepeviktor avatar May 02 '21 16:05 szepeviktor

Even cooler that you're trying to help out :hugs: Cudos! :sunglasses:

I figured out the problem, and maybe I'll get around to fixing it tonight. I'll fix it in your PR.

mihaeu avatar May 02 '21 17:05 mihaeu