Bento
Bento copied to clipboard
migueravila
🔤 Added customizable title support and 🌙 Automatic dark mode switching (sunrise/sunset)
This should have been 2 PR's! You caught me off-guard with that refactor commit and I messed up my merge :/
🌙 Automatic theme switching from location
- Use lat/long | browser location data to automatically set light/dark mode.
- Sunrise/sunset is already returned in the openweathermap API, so this is fairly simple.
- Converted the functions in weather.js to async as opposed to using .then chains
🔤 Customizable titles
Currently, changing the title isn't too difficult but it's a bit more annoying to do in Docker.
- Added a script to set the window's title from a value set in config.js
This could be in the <head> but a file fits the style.
Hi! @lewisdoesstuff I loved the title feature. But the Automatic theme switch is already implemented here!
Ah, that would have saved me a while. Does this sync the theme from location automatically, or just pull it from the OS's theme?
I don't use auto light/dark on my OS, but I do toggle light mode in the day on Bento; I assume I'm not the only one who does this so I thought it'd be useful
Hi @lewisdoesstuff I love the location automatically change but some people just needs to change it at the time they want and having two automatically change features can be confusing. I'll accept the PR for the custom title feature (And I'll read the other PR you have) Thank you!
Sounds good! Not a problem.
I'm maintaining my own fork at lewisdoesstuff/bento-next with any features that are out of the scope of this, feel free to grab anything you think fits!